Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs in test_gbt_formulation #157

Open
jezsadler opened this issue Jun 20, 2024 · 1 comment
Open

TODOs in test_gbt_formulation #157

jezsadler opened this issue Jun 20, 2024 · 1 comment
Assignees
@jezsadler

Comments

@jezsadler
Copy link
Collaborator

A couple of TODO items in this test file:

  1. line 34, # TODO @cog-imperial: fix below?: - unclear what this is referring to
  2. line 49, # TODO @cog-imperial: did we remove categorical variables intentionally?, followed by a test for a model with categorical variables. We should make a decision on whether to remove this and either restore or remove the test.
@jezsadler jezsadler self-assigned this Jun 21, 2024
@jezsadler
Copy link
Collaborator Author

Removed these (and the commented test) in my fork, will close on integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jezsadler jezsadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jezsadler