Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test notebooks using testbook or delete TODO comment #159

Open
jezsadler opened this issue Jun 20, 2024 · 1 comment
Open

Test notebooks using testbook or delete TODO comment #159

jezsadler opened this issue Jun 20, 2024 · 1 comment
Assignees
@carldlaird

Comments

@jezsadler
Copy link
Collaborator

jezsadler commented Jun 20, 2024 •
edited
Loading

Per test_run_notebooks.py, line 15:

# TODO @cog-imperial: These will be replaced with stronger tests using testbook soon

We should either replace the tests or delete the TODO.
@rmisener
Copy link
Member

rmisener commented Jun 21, 2024 •
edited
Loading

Hi @carldlaird, this is a TODO of yours from a couple years ago. Can we just delete this or move to the discussions? Or is this important and we should get someone on it? Just looking for context.

@rmisener rmisener assigned rmisener and carldlaird and unassigned rmisener Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carldlaird carldlaird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmisener @carldlaird @jezsadler