Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ContextManager for io submodules ? #192

Closed
vincentsarago opened this issue Jun 18, 2020 · 0 comments · Fixed by #196
Closed

Using ContextManager for io submodules ? #192

vincentsarago opened this issue Jun 18, 2020 · 0 comments · Fixed by #196

Comments

@vincentsarago
Copy link
Member

Started in #124 (comment) I submitted the idea of using context manager for rio-tiler readers.

This is a really big change and when I started working on rio-tiler==2.0 I decided to not introduce this because I wanted to focus on other parts of the code.

Now we are close to a beta release (most of the new features have been tested and approved) It might be a good time to introduce the ContextManager form.

I've already re-written rio-tiler-crs with context manager https://github.com/cogeotiff/rio-tiler-crs#api

👍 / 👎 ?

Note: we could also let all the code as it is and just add a COGReader class !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant