Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of x, y, z parameters are inconsistent across methods #415

Closed
jseppi opened this issue Aug 27, 2021 · 0 comments
Closed

Order of x, y, z parameters are inconsistent across methods #415

jseppi opened this issue Aug 27, 2021 · 0 comments

Comments

@jseppi
Copy link
Contributor

jseppi commented Aug 27, 2021

It would be nice if the ordering of x, y, z parameters are consistent across methods. Kind of a minor thing, but can cause mistakes that could be easily avoidable.

z, x, y ordering in tile_exists:

def tile_exists(self, tile_z: int, tile_x: int, tile_y: int) -> bool:

x, y, z ordering in tile:

def tile(self, tile_x: int, tile_y: int, tile_z: int, **kwargs: Any) -> ImageData:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants