Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add relationships resource api #423

Merged
merged 12 commits into from
Sep 28, 2020
Merged

feat: add relationships resource api #423

merged 12 commits into from
Sep 28, 2020

Conversation

mrtraser
Copy link
Contributor

@mrtraser mrtraser commented Sep 3, 2020

No description provided.

@mrtraser mrtraser marked this pull request as ready for review September 4, 2020 09:26
@mrtraser mrtraser requested a review from a team as a code owner September 4, 2020 09:26
@mrtraser mrtraser requested a review from a team September 4, 2020 09:26
polomani
polomani reviewed Sep 4, 2020
View reviewed changes
packages/beta/package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #423 into master will increase coverage by 0.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   88.83%   89.55%   +0.71%     
==========================================
  Files          61       66       +5     
  Lines        1711     1819     +108     
  Branches      218      238      +20     
==========================================
+ Hits         1520     1629     +109     
+ Misses        181      180       -1     
  Partials       10       10
Impacted Files Coverage Δ
...ges/beta/src/api/relationships/relationshipsApi.ts 100.00% <100.00%> (ø)
packages/beta/src/cogniteClient.ts 100.00% <100.00%> (ø)
packages/wells/src/client/cogniteClient.ts 100.00% <0.00%> (ø)
packages/wells/src/client/api/wells.ts 100.00% <0.00%> (ø)
packages/wells/src/__tests__/testUtils.ts 100.00% <0.00%> (ø)
packages/wells/src/client/api/utils.ts 100.00% <0.00%> (ø)
packages/core/src/utils.ts 90.90% <0.00%> (+1.16%) ⬆️
packages/core/src/testUtils.ts 34.48% <0.00%> (+1.72%) ⬆️

polomani
polomani reviewed Sep 4, 2020
View reviewed changes
scripts/extractCodeSnippets.js Outdated Show resolved Hide resolved
packages/stable/src/__tests__/api/labels.int.spec.ts Outdated Show resolved Hide resolved
packages/beta/src/types.ts Outdated Show resolved Hide resolved
polomani
polomani approved these changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite easy to add new apis, good sign
(at least so far)

@mrtraser mrtraser merged commit f51e21c into master Sep 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhenriques hhenriques hhenriques left review comments

@polomani polomani polomani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrtraser @polomani @hhenriques