-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for variables and operationName for templates #591
feat: added support for variables and operationName for templates #591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
===========================================
- Coverage 98.69% 77.41% -21.29%
===========================================
Files 19 89 +70
Lines 764 3090 +2326
Branches 51 394 +343
===========================================
+ Hits 754 2392 +1638
- Misses 10 697 +687
- Partials 0 1 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
After approval, is it correct that I shall merge this as blow to get it released?
|
You have degraded test coverage or test coverage is wrong. I don't see any specifically wrong with PR itself ;) Ive seen |
Yes, seems like it is checking against a very old commit for coverage. Not sure how to fix, any ideas? The ! Is for breaking changes I think... |
@peternic We had issues with major releases previously, please reach out if you face it :) PS. ignore codecov |
Added support for variables and operation name to the templates graphql. This will make it possible to use codegen to generate and compiletime check queries.
So need to be able to pass in the variables and the operationName through the sdk.