Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix FindTransaction Regression #207

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 14, 2020

Related: coinbase/mesh-sdk-go#280

This PR fixes a regression introduced by #269 where FindTransaction returns a pruning-related error when querying for a transaction added in the same DatabaseTransaction.

Changes

  • update rosetta-sdk-go
  • update version

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6648

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.737%

Totals Coverage Status
Change from base Build 6644: 0.0%
Covered Lines: 521
Relevant Lines: 887

💛 - Coveralls

@patrick-ogrady patrick-ogrady requested a review from yfl92 December 14, 2020 21:11
@patrick-ogrady patrick-ogrady merged commit 8482a20 into master Dec 14, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/fix-findtransaction-regression branch December 14, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants