[storage] Interface Overhaul #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Nov 25, 2020
| @@ -171,15 +171,15 @@ func PerformanceBadgerOptions(dir string) badger.Options { | |||
| // This option will have a significant effect the memory. If the level is kept | |||
| // in-memory, read are faster but the tables will be kept in memory. By default, | |||
| // this is set to false. | |||
| opts.KeepL0InMemory = false | |||
| opts.KeepL0InMemory = true | |||
There was a problem hiding this comment.
In practice, we saw this decrease read/write latency. In the future, we should probably write some benchmarks that allow us to compare db config changes more quantitatively.
Pull Request Test Coverage Report for Build 12205
💛 - Coveralls |
patrick-ogrady
commented
Nov 25, 2020
yfl92
approved these changes
Nov 25, 2020
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/coinbase/rosetta-sdk-go/tree/patrick/priority-lock
This PR updates the
storageinterface to provide access to more granular database locking and updates all files instorageto use this new interface.Future Work
Overhaul
BlockStorage,BalanceStorage, andCoinStorageto useWriteTransactionto reduce usage of global locking (i.e. pruning/reconciliation don't need to acquire the global database lock).