Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Operations using High-Level Descriptions #33

Merged
merged 6 commits into from
May 22, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 22, 2020

Motivation

When parsing operations in a group, it is necessary to perform a variety of repetitive checks to ensure expected operations are present.

Solution

Make it possible to describe expected operations at a high-level to error-checking code (take a look at the tests for an example of what this looks like). If a slice of operations do not meet the high-level expectations, an error can be returned.

Future PR

Add examples describing how to use parsing library (#34).

@patrick-ogrady patrick-ogrady force-pushed the patrick/group-requirements branch from 40a6db7 to dc8015c Compare May 22, 2020 02:47
@coveralls
Copy link

coveralls commented May 22, 2020

Pull Request Test Coverage Report for Build 1467

  • 172 of 212 (81.13%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 65.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/match_operations.go 146 186 78.49%
Totals Coverage Status
Change from base Build 1383: 1.4%
Covered Lines: 1434
Relevant Lines: 2178

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title Match Operations Match Operations using High-Level Descriptions May 22, 2020
@patrick-ogrady patrick-ogrady requested a review from etscrivner May 22, 2020 02:53
@patrick-ogrady patrick-ogrady changed the title Match Operations using High-Level Descriptions Parse Operations using High-Level Descriptions May 22, 2020
@patrick-ogrady patrick-ogrady requested a review from omarish May 22, 2020 02:56
@patrick-ogrady patrick-ogrady merged commit 25e8335 into master May 22, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/group-requirements branch May 22, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants