Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make types a go module #461

Merged
merged 4 commits into from
Dec 12, 2022
Merged

make types a go module #461

merged 4 commits into from
Dec 12, 2022

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Dec 7, 2022 •
edited
Loading

Fixes #460 .

Motivation

rosetta-sdk-go dependency graph is quite big and all of them are not useful for rosetta development. This makes it hard to use rosetta-sdk-go

Solution

Make types as go submodule so that people can just import types independent of rosetta-sdk-go

Open questions

@shrimalmadhur shrimalmadhur mentioned this pull request Dec 7, 2022
Closed
@shrimalmadhur shrimalmadhur merged commit 8ea45ef into master Dec 12, 2022
@shrimalmadhur shrimalmadhur deleted the madhur/modularize-generated-pkg branch December 12, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingweicb jingweicb jingweicb approved these changes

@GeekArthur GeekArthur Awaiting requested review from GeekArthur

@xiaying-peng xiaying-peng Awaiting requested review from xiaying-peng

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an auto-generated type package
2 participants
@shrimalmadhur @jingweicb