Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Miscellaneous Nits Before Release #259

Merged
merged 10 commits into from
Dec 1, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 1, 2020

This PR fixes a few miscellaneous issues found while integrating rosetta-sdk-go into rosetta-cli (coinbase/mesh-cli#193).

Changes

@coveralls
Copy link

coveralls commented Dec 1, 2020

Pull Request Test Coverage Report for Build 12936

  • 13 of 19 (68.42%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 78.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage/modules/balance_storage.go 13 15 86.67%
storage/modules/counter_storage.go 0 4 0.0%
Totals Coverage Status
Change from base Build 12840: -0.03%
Covered Lines: 7896
Relevant Lines: 10104

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants