Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][reconciler] Handle Skipped Reconciliations Correctly #266

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 4, 2020

This PR fixes a few bugs in the reconciler that can halt syncing and/or prevent shutdown. Shoutout to @yflinn
for posting about these issues!

Changes

  • continue after ReconciliationSkipped in queueChanges [Caused sync halt]
  • release lock inactiveQueueMutex when skipping account in reconcileInactiveAccounts [Prevents shutdown]

@coveralls
Copy link

coveralls commented Dec 4, 2020

Pull Request Test Coverage Report for Build 13167

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 87 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 78.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
reconciler/reconciler.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
storage/modules/key_storage.go 4 69.86%
utils/utils.go 30 63.72%
constructor/worker/worker.go 53 80.57%
Totals Coverage Status
Change from base Build 13123: 0.01%
Covered Lines: 7914
Relevant Lines: 10095

💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 3dbb551 into master Dec 4, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/fix-skip-halt branch December 4, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants