Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[constructor] Add set_blob and get_blob to DSL #277

Merged
merged 2 commits into from
Dec 11, 2020
Merged

[constructor] Add set_blob and get_blob to DSL #277

merged 2 commits into from
Dec 11, 2020

Conversation

patrick-ogrady
Copy link
Contributor

Related: #276

This PR adds support for set_blob and get_blob to the Rosetta DSL parser.

@patrick-ogrady patrick-ogrady requested a review from yfl92 December 11, 2020 21:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13739

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.052%
Totals Coverage Status
Change from base Build 13722: 0.0%
Covered Lines: 8119
Relevant Lines: 10402
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 51ec84a into master Dec 11, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/dsl-nits branch December 11, 2020 21:24
@patrick-ogrady patrick-ogrady mentioned this pull request Dec 11, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @yfl92