Transactions in unsynced blocks no-longer assumed pruned #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
force-pushed
the
will/construction-block-incorrectly-marked-as-pruned
branch
3 times, most recently
from
fd47f4c to
411bdef
Compare
williamberman
force-pushed
the
will/construction-block-incorrectly-marked-as-pruned
branch
from
411bdef to
45c0b2b
Compare
patrick-ogrady
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Previously, searching for transactions in unsynced blocks would return an error saying that the transaction was in a pruned block. Really, the transactions are present but in blocks past the synced head, which should return no transaction but with no error.
Solution
Additional check for if transaction seen in unseen block.
Open questions