Skip to content

Commit

Permalink
Not using utils.isEmpty on non objects (prebid#6036)
Browse files Browse the repository at this point in the history
* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

prebid#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.

* Merge branch 'master' of https://github.com/prebid/Prebid.js

# Conflicts:
#	modules/telariaBidAdapter.js

Added GDPR support

* Sending the gdpr & gdpr consent string only if they're defined

* - Updated the test ad unit to use 'telaria' as the bidder code.
- Added an example URL.

* using the bidder code constant

* - Implemented the 'onTimeout' callback to fire a pixel when there's a timeout.
- Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md

* some mods to the schain tag generation

* - added tests for schain param checking.

* - fixed a malformed url for timeouts

* - Removed a trailing ',' while generating a schain param.

* - Using the schain object from validBidRequest if present. Reverting to checking if params has it if not.

* - reverting changes to merge with master

* - Resolving merge issues

* - some formatting changes

* using val !== '' instead of utils.isEmpty(val)

* Checking for undefined in the getEncodedValIfNotEmpty method

Co-authored-by: Vinay Prasad <vprasad@tremorvideo.com>
Co-authored-by: Vinay Prasad <vprasad@telaria.com>
  • Loading branch information
3 people authored and stsepelin committed May 28, 2021
1 parent c1bef52 commit 7eed715
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/telariaBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function getDefaultSrcPageUrl() {
}

function getEncodedValIfNotEmpty(val) {
return !utils.isEmpty(val) ? encodeURIComponent(val) : '';
return (val !== '' && val !== undefined) ? encodeURIComponent(val) : '';
}

/**
Expand Down

0 comments on commit 7eed715

Please sign in to comment.