Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for committer status #31

Open
mxgrey opened this issue Mar 21, 2024 · 7 comments
Open

Request for committer status #31

mxgrey opened this issue Mar 21, 2024 · 7 comments

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Mar 21, 2024

The cargo extensions for colcon are very important if the ROS community is to benefit from the growing Rust ecosystem.

Unfortunately these extensions have been unmaintained for a while, as there are several small but crucial bug fixes that have been sitting in PRs for months without review.

I'd like to request committer status for myself to help move these PRs along. It would also be good to get committer status on colcon-ros-cargo so I can help there as well.

And to avoid a bus factor of 1, I would also recommend committer status for @luca-della-vedova who is also working very actively on bringing ROS and Rust together.

@nuclearsandwich
Copy link
Contributor

FYI @lelongg (as the initial colcon-cargo admin).

The colcon org admins will grant this request in 7 days if there are no objections from current maintainers.

If current maintainers approve, we can grant the request earlier.

@mxgrey
Copy link
Contributor Author

mxgrey commented Apr 1, 2024

We're a healthy margin past the 7-day window with no objection. How do you feel about moving forward with granting permissions, @nuclearsandwich ?

@nuclearsandwich
Copy link
Contributor

nuclearsandwich commented Apr 4, 2024

Invitations to join the org have been dispatched.
I have also removed inactive members in the interest of limiting access to active contributors.
Anyone who was removed and wishes to contribute in the future can request to be added back.

@mxgrey @luca-della-vedova please close this issue once you have accepted the invites and confirmed your access.

@mxgrey
Copy link
Contributor Author

mxgrey commented Apr 12, 2024

Looks like commit rights are working for both of us, thanks!

@luca-della-vedova
Copy link
Member

Invitations to join the org have been dispatched. I have also removed inactive members in the interest of limiting access to active contributors. Anyone who was removed and wishes to contribute in the future can request to be added back.

@mxgrey @luca-della-vedova please close this issue once you have accepted the invites and confirmed your access.

Hi @nuclearsandwich, it seems @esteve might have been removed but he is still an active member of the community and contributor, is it possible to add him back?

@esteve
Copy link
Contributor

esteve commented Aug 29, 2024

@luca-della-vedova thanks

@nuclearsandwich yeah, IIRC I had admin rights, but this ticket went under the radar. I probably missed all this because it was during Easter, from when it was opened to when it was closed. In any case, these extensions didn't have much activity, but are definitely not unmaintained

@nuclearsandwich
Copy link
Contributor

The invitation has been sent out to @esteve to restore access. Apologies for the misunderstanding. In general I'd like to keep maintainer access to active contributors in order to re-verify maintainers returning from a break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants