Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atty has a cve and could be replaced by is-terminal #127

Closed
nstinus opened this issue Feb 16, 2023 · 1 comment
Closed

atty has a cve and could be replaced by is-terminal #127

nstinus opened this issue Feb 16, 2023 · 1 comment

Comments

@nstinus
Copy link

nstinus commented Feb 16, 2023

warning[unsound]: Potential unaligned read
  ┌─ Cargo.lock:4:1
  │
4 │ atty 0.2.14 registry+https://github.com/rust-lang/crates.io-index
  │ ----------------------------------------------------------------- unsound advisory detected
  │
  = ID: RUSTSEC-2021-0145
  = Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0145
  = On windows, `atty` dereferences a potentially unaligned pointer.
    
    In practice however, the pointer won't be unaligned unless a custom global allocator is used.
    
    In particular, the `System` allocator on windows uses `HeapAlloc`, which guarantees a large enough alignment.
    
    # atty is Unmaintained
    
    A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.
    
    Last release of `atty` was almost 3 years ago.
    
    ## Possible Alternative(s)
    
    The below list has not been vetted in any way and may or may not contain alternatives;
    
     - [is-terminal](https://crates.io/crates/is-terminal)
     - std::io::IsTerminal *nightly-only experimental*
  = Announcement: https://github.com/softprops/atty/issues/50
  = Solution: No safe upgrade is available!
  = atty v0.2.14
    └── colored v2.0.0
@nstinus
Copy link
Author

nstinus commented Feb 17, 2023

Already fixed by #122

@nstinus nstinus closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant