Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump windows-sys crate to 0.52 #182

Closed
king-11 opened this issue Nov 2, 2024 · 10 comments · Fixed by #184
Closed

bump windows-sys crate to 0.52 #182

king-11 opened this issue Nov 2, 2024 · 10 comments · Fixed by #184

Comments

@king-11
Copy link
Contributor

king-11 commented Nov 2, 2024

windows-sys had a release after 8 months which covers a lot of fixes and changes now they are regularly updating as well.

since coloured relies on 0.48 its pulling that while most other crates have updated to 0.52 atleast causing duplicate dependencies.

@spenserblack
Copy link
Collaborator

If the subsequent versions didn't break our usage, we might want to expand the version range to >= x.y, <= 0.52 for max compatibility.

But for simple version bumps, #178 should resolve this and others.

@spenserblack
Copy link
Collaborator

According to the passing CI jobs in #183 we can actually expand the version range to >= 0.48, <= 0.59.

@king-11
Copy link
Contributor Author

king-11 commented Nov 2, 2024

That sounds great already were prepared for it any reason for withholding it?

@spenserblack
Copy link
Collaborator

any reason for withholding it?

I just merged in #178 so #183 was just created, so it's a bit too recent to be considered withheld 😆 I'd accept a PR to apply the version range I'm recommending instead of the "simple" version bump in #183.

@king-11
Copy link
Contributor Author

king-11 commented Nov 2, 2024

ouch sorry for not taking a look at date it was created just getting a range PR ready thanks for quick response :)

@king-11
Copy link
Contributor Author

king-11 commented Nov 3, 2024

Closing the issue as PR is merged but this would require a new release as well for downstream resources to consume.

@king-11
Copy link
Contributor Author

king-11 commented Nov 14, 2024

@spenserblack would it be possible to have a minor version release or is there some cycle that is followed which would include this?

@spenserblack
Copy link
Collaborator

Collaborators don't always have full access to do everything necessary for a new release (e.g. publishing to package repositories), so I generally avoid creating releases when I'm just a collaborator. For example, I wouldn't make a new release myself in onefetch.

But, luckily, the publish workflow should take care of everything, so I think I can make a release if nobody else is available. I just need to double-check the changes since the last release to know which version to bump to.

@spenserblack spenserblack mentioned this issue Nov 14, 2024
1 task
@spenserblack
Copy link
Collaborator

#185

Please don't hesitate to remind me if I don't make a new release next month 😆

@king-11
Copy link
Contributor Author

king-11 commented Nov 14, 2024

Sounds good thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants