feature: Make usable without atty. #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwittenborn
force-pushed
the
master
branch
3 times, most recently
from
744b5dd
to
1921f20
Compare
hwittenborn
requested changes
Jul 3, 2023
src/control.rs
Outdated
Comment on lines
106
to
112
| #[allow(unused_mut)] | ||
| let mut tty: Option<bool> = None; | ||
|
|
||
| #[cfg(feature = "tty")] | ||
| { | ||
| tty = Some(atty::is(atty::Stream::Stdout)); | ||
| } |
There was a problem hiding this comment.
The Option could just be removed, right?
#[allow(unused_mut)]
let mut tty = false;
#[cfg(feature = "tty")]
{
tty = atty::is(atty::Stream::Stdout);
}
|
Ignore the CI failing, that's due to all the features not being enabled. I'll get that fix shortly. |
|
Hey, @shanecelis, I've gone ahead and replaced |
|
Great. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking about using this crate with bevy for doing colored text without any tty in sight. This merely adds a feature 'tty' that is by default on, so no change unless opted-in.