Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect XCM Junctions #51

Closed
marshacb opened this issue Oct 23, 2024 · 1 comment · Fixed by #54
Closed

Fix Incorrect XCM Junctions #51

marshacb opened this issue Oct 23, 2024 · 1 comment · Fixed by #54

Comments

@marshacb
Copy link
Contributor

It seems the following commits have introduced invalid xcm junctions to some xcmV1MultiLocations:

An example of this can be seen here where the GeneralKey junction is an array ([{"generalKey": {"length": 2, "data": "0x0101000000000000000000000000000000000000000000000000000000000000"}}] when it should be the second index of the X2 Junctions type as an object {"generalKey": {"length": 2, "data": "0x0101000000000000000000000000000000000000000000000000000000000000"}}
@marshacb marshacb changed the title Fix Incorrect Xcm Junctions Fix Incorrect XCM Junctions Oct 23, 2024
@ryanleecode ryanleecode mentioned this issue Nov 4, 2024
Merged
@dudo50
Copy link

dudo50 commented Nov 12, 2024

cc @mkchungs , any progress on this?

@marshacb marshacb mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Ensure Location Junctions Are Not Nested Arrays marshacb/xcm-global-registry
2 participants
@marshacb @dudo50