Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot refresh coverage page directly in version '0.12.0' #94

Closed
HansBug opened this issue Feb 22, 2020 · 4 comments · Fixed by #97
Closed

Cannot refresh coverage page directly in version '0.12.0' #94

HansBug opened this issue Feb 22, 2020 · 4 comments · Fixed by #97

Comments

@HansBug
Copy link

HansBug commented Feb 22, 2020

In version 0.11.0, when I open a coverage page (with anchor, like http://coverage.core.ips.net/#8fa08b9ca3d22133f6daaa36049fcd5a9e1ef472), after some of the code in this page has changed, I can directly refresh the page, then the new code and coverage situation can be displayed.

But in version 0.12.0, when I do this (something even there is no change with the code), the page will be in loading status endlessly (the progress bar will act continuously, but no code and coverage displayed). This happens in all the coverage pages.

I'm not sure whether this is a new feature in version 0.12.0 or a bug, maybe maintainers can check this?

@PragTob
Copy link
Collaborator

PragTob commented Feb 22, 2020

Most likely a bug related to the wild JS updates.

Might also still be deleted to the pagination, as I think datatables tries to pull something from some server.. idk.

Sorry for the mess. Hope to gradually fix all this, stick to the old version until then and sorry for the inconvenience :(

@PragTob
Copy link
Collaborator

PragTob commented Feb 23, 2020

Definitely not intended. Still unsure/when how this happend.

It's not related to the pagination though, even with the pagination fix I still have this behaviour sadly.

Error: Syntax error, unrecognized expression: a.src_link[href=#b4b6c5440441f74b61f7568511ee73b99e2b9da6]

Not sue what's going wrong here. If anyone wants to investigate, please do. In my mind it's either the JS updates or maybe the hiding of the container: #29

There aren't many commits that could have broken it so a git bisect would probably also go a long way.

@HansBug
Copy link
Author

HansBug commented Feb 23, 2020

Emmm, I did not found any javascript or network failure in the frontend when this happened. So I'm not sure whether this problem is caused by frontend or not, sorry for that.

@HansBug
Copy link
Author

HansBug commented Feb 24, 2020

Some additional information for version 0.12.1 :
Problem in issue #92 is ok now, but this issue (#94) still exist. This time I find this failure in browser console(chrome) when refresh the page with anchor:

application.js:1 Uncaught Error: Syntax error, unrecognized expression: a.src_link[href=#39b00e29519d0795244531d8048d1be589825c0a]
    at Function.w.error (application.js:1)
    at w.tokenize (application.js:2)
    at w.select (application.js:2)
    at Function.w [as find] (application.js:1)
    at Te.fn.init.find (application.js:2)
    at new Te.fn.init (application.js:2)
    at Te (application.js:1)
    at HTMLDocument.<anonymous> (application.js:7)
    at t (application.js:2)
    at a (application.js:2)

Steps to reproduce this failure:

  1. Open the coverage home page
  2. Select one line, click it, then the coverage detail of the chosen ruby file will be displayed
  3. Press F5 (do refresh) at this moment, then the failure above will appear

Wish these information can help you :)

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 8, 2020
Update ruby-simplecov-html to 0.12.2.


0.12.2 (2020-02-27)
==================

## Bugfixes
* Refreshing the page while a source file is open works again. Thanks [@HansBug](https://github.com/HansBug) for the report [#94](simplecov-ruby/simplecov-html#94) and [@Tietew](https://github.com/Tietew) for the fix!

0.12.1 (2020-02-23)
==================

Bugfix release to fix huge bugs that sadly test suit and maintainters didn't catch.

## Bugfixes
* Disable pagination and with it all files on 2nd page+ being broken/not able to open
* Fix display of non ASCII characters, for this you have to upgrade to simplecov 0.18.3 though (it's handled in there)

0.12.0 (2020-02-12)
==================

This release is basically a collection of long standing PRs finally merged.
Yes it looks different, no it's not a redesign - just a side effect of lots of dependency updates to improve CSP compatibility.

## Enhancements
* The HTML should now be servable with CSP settings of `default-src 'none'; script-src 'self'; img-src 'self'; style-src 'self';`
* File list is horizontally scrollable if the space doesn't suffice
* numbers are now right aligned and displayed with the same number of decimals for easier comparison and reading.

## Bugfixes
* Make sorting icons appear again
* close link tag which could cause problems when parsing as xhtml/xml
* make sure encoding errors won't crash the formatter
* When viewing a short source file while you have a big file list you will no longer be able to scroll on after the source file has ended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants