Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental compilation issues in large(ish) projects #2003

Closed
alexarchambault opened this issue Aug 24, 2022 · 4 comments
Closed

Incremental compilation issues in large(ish) projects #2003

alexarchambault opened this issue Aug 24, 2022 · 4 comments
Milestone

Comments

@alexarchambault
Copy link
Contributor

In the Scala CLI, but also in the coursier or Almond builds, we've been seeing consistently issues with incremental compilation. IIRC, these were things like whole module being re-compiled upon simple source changes that shouldn't require it.

These were frequent enough that we switched to mill-scala-cli to handle compilation in those projects (even it though it has some drawbacks). These issues are also quite hard or time-consuming to reproduce, and even more so to minimize. Which is quite frustrating, and is also why this wasn't reported earlier.

Sorry about the vague description here, I usually don't open issues if I don't have at least a repro, but I guess you asked for it ^^

@alexarchambault
Copy link
Contributor Author

If you want to build Scala CLI without the mill-scala-cli plugin, you can add a line such as

  def enableScalaCli = false

right below this one.

@lefou
Copy link
Member

lefou commented Aug 24, 2022

Thanks for reporting. Although the description is vague, we recently fixed an issue with incremental compilation in 0.10.5, which could also be the cause for your observations.

It would be very helpful, if you could check whether a recent version of Mill >= 0.10.5 fixes your issues as well.

@alexarchambault
Copy link
Contributor Author

Closing this issue… As of VirtusLab/scala-cli#1335 (that uses Mill 0.10.7), it seems the incremental compilation issues went away. It seems to be the same on the coursier build, where I had enabled mill-scala-cli too.

@lefou
Copy link
Member

lefou commented Oct 19, 2022

Thanks for checking and reporting! This issue was already fixed in Mill 0.10.5 then.

@lefou lefou modified the milestones: next major, 0.10.5 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants