Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Settings mixin and use .nsdUploadButton prop #307

Open
juancho0202 opened this issue Jan 16, 2024 · 2 comments
Open

Removing Settings mixin and use .nsdUploadButton prop #307

juancho0202 opened this issue Jan 16, 2024 · 2 comments
Labels

Comments

@juancho0202
Copy link

juancho0202 commented Jan 16, 2024

Related to #306

Currently the Settings Mixin in the compas-open-scd package is a slightly modified version of the Settings mixin in the open-scd package with the sole difference of removing the lines that allow users to load custom nsdoc files.

OpenSCD already features a way to disable that button via a prop https://github.com/openscd/open-scd/blob/56cc548de4311dd7a0c92bd514d313896b08482f/packages/open-scd/src/addons/Settings.ts#L116C3-L116C18

Acceptance criteria:

  • The settings mixin is removed from compas-open-scd
  • We pass down to the <open-scd> tag a prop called nsdUploadButton = false
@juancho0202 juancho0202 changed the title Removing Settings Mixin from CoMPAS OSCD Removing all open-scd mixins from compas-open-scd Mar 6, 2024
@juancho0202 juancho0202 changed the title Removing all open-scd mixins from compas-open-scd Removing Settings mixin from compas-open-scd Apr 10, 2024
@juancho0202
Copy link
Author

juancho0202 commented Apr 10, 2024

On hold until #324 (Update compas-open-scd with the latest version of open-scd) is done

@juancho0202 juancho0202 changed the title Removing Settings mixin from compas-open-scd Removing Settings mixin from compas-open-scd and use .nsdUploadButton prop Apr 24, 2024
@juancho0202 juancho0202 changed the title Removing Settings mixin from compas-open-scd and use .nsdUploadButton prop Removing Settings mixin and use .nsdUploadButton prop Apr 24, 2024
Copy link

Hello there,

Thank you for opening this issue! We appreciate your interest in our project.
However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better.
Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve.
Thank you for being part of this journey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant