-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Settings mixin and use .nsdUploadButton
prop
#307
Comments
On hold until #324 (Update compas-open-scd with the latest version of open-scd) is done |
.nsdUploadButton
prop
.nsdUploadButton
prop.nsdUploadButton
prop
Hello there, Thank you for opening this issue! We appreciate your interest in our project. If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better. If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later. Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve. |
Related to #306
Currently the Settings Mixin in the
compas-open-scd
package is a slightly modified version of the Settings mixin in theopen-scd
package with the sole difference of removing the lines that allow users to load custom nsdoc files.OpenSCD already features a way to disable that button via a prop https://github.com/openscd/open-scd/blob/56cc548de4311dd7a0c92bd514d313896b08482f/packages/open-scd/src/addons/Settings.ts#L116C3-L116C18
Acceptance criteria:
<open-scd>
tag a prop called nsdUploadButton = falseThe text was updated successfully, but these errors were encountered: