Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#302): Add new get Ldevice Status method #301

Merged

Conversation

gleizesDor
Copy link
Contributor

No description provided.

@gleizesDor gleizesDor force-pushed the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch 3 times, most recently from e29d543 to 190a02a Compare July 26, 2023 13:12
@samirromdhani
Copy link
Contributor

How do I correctly review this? RSR-770 it does not appear to be the right issue.
It would be better to connect it to the appropriate issue and give the pull request a nice English name ;)

@gleizesDor gleizesDor linked an issue Jul 28, 2023 that may be closed by this pull request
@gleizesDor gleizesDor force-pushed the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch from 190a02a to 64e2327 Compare July 28, 2023 09:23
supress LdeviceStatus constant

Signed-off-by: gleizesDor <115622893+gleizesDor@users.noreply.github.com>
@gleizesDor gleizesDor force-pushed the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch from 64e2327 to f51ede5 Compare July 28, 2023 09:25
@gleizesDor gleizesDor changed the title feat(RSR-770): Ajout d'une methode de recupération du Ldevice statut beaucoup plus simple feat(#302): Add new get Ldevice Status method Jul 28, 2023
@samirromdhani samirromdhani self-requested a review July 28, 2023 13:32
Copy link
Contributor

@samirromdhani samirromdhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gleizesDor, the branch name needs to be adjusted feat/RSR-770_Refacto_LDGRPService_configureLDGRP

@samirromdhani samirromdhani deleted the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch July 31, 2023 12:59
@samirromdhani samirromdhani restored the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch July 31, 2023 13:00
@samirromdhani samirromdhani reopened this Jul 31, 2023
@samirromdhani samirromdhani deleted the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch July 31, 2023 13:01
@samirromdhani samirromdhani restored the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch July 31, 2023 13:01
@samirromdhani samirromdhani reopened this Jul 31, 2023
@samirromdhani samirromdhani merged commit 3da0cc2 into develop Jul 31, 2023
@samirromdhani samirromdhani deleted the feat/RSR-770_Refacto_LDGRPService_configureLDGRP branch July 31, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new get Ldevice Status method
2 participants