Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include proof of reserves in quote #1749

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Include proof of reserves in quote #1749

wants to merge 1 commit into from

Conversation

binarybaron
Copy link
Collaborator

@binarybaron binarybaron commented Aug 7, 2024 •
edited
Loading

Closes #1743

  • Attach peer id of Alice to reserve proof (message)
  • Warn if reserve proof is missing
  • Abort if reserve proof is present but invalid
  • Only proof the amount required for max amount by quote to hide total balance
  • Debate if we want to require reserve proof or make it optional

@binarybaron binarybaron marked this pull request as draft August 7, 2024 12:57
@binarybaron
Copy link
Collaborator Author

Closes #1743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach monero reserve proof to quote
1 participant
@binarybaron