From 746f96551ee9b7dca760d3ad72fd1728d2a3ae57 Mon Sep 17 00:00:00 2001 From: Alexandre Nobuharu Sato <66435071+AlexandreSato@users.noreply.github.com> Date: Sat, 31 Aug 2024 15:30:39 -0300 Subject: [PATCH 1/3] ci: Bot comment only for first timers and collapsible sections for UI screenshots Added also implement collapsible sections for UI screenshots #33415 --- .github/workflows/auto_pr_review.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/auto_pr_review.yaml b/.github/workflows/auto_pr_review.yaml index abcebd1d64..6367bc7342 100644 --- a/.github/workflows/auto_pr_review.yaml +++ b/.github/workflows/auto_pr_review.yaml @@ -33,18 +33,18 @@ jobs: already-exists-comment: "Your PR should be made against the `master` branch" # Welcome comment - - name: comment - uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 + - name: "First timers PR" + uses: actions/first-interaction@v1 if: github.event.pull_request.head.repo.full_name != 'commaai/opendbc' with: - message: | + repo-token: ${{ secrets.GITHUB_TOKEN }} + pr-message: | - Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following: + Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following: * Convert your PR to a draft unless it's ready to review * Read the [contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md) * Before marking as "ready for review", ensure: * the goal is clearly stated in the description * all the tests are passing + * the change is [something we merge](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-gets-merged) * include a route or your device' dongle ID if relevant - comment_tag: run_id - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 44187097dab82f7954cd6015b9b7f369958ba81e Mon Sep 17 00:00:00 2001 From: Alexandre Nobuharu Sato <66435071+AlexandreSato@users.noreply.github.com> Date: Sat, 31 Aug 2024 15:32:52 -0300 Subject: [PATCH 2/3] fix --- .github/workflows/auto_pr_review.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/auto_pr_review.yaml b/.github/workflows/auto_pr_review.yaml index 6367bc7342..ff57583348 100644 --- a/.github/workflows/auto_pr_review.yaml +++ b/.github/workflows/auto_pr_review.yaml @@ -40,7 +40,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} pr-message: | - Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following: + Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following: * Convert your PR to a draft unless it's ready to review * Read the [contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md) * Before marking as "ready for review", ensure: From 324591bda68815eb06d03848130c0de39587be13 Mon Sep 17 00:00:00 2001 From: Alexandre Nobuharu Sato <66435071+AlexandreSato@users.noreply.github.com> Date: Sat, 31 Aug 2024 15:35:30 -0300 Subject: [PATCH 3/3] Update auto_pr_review.yaml --- .github/workflows/auto_pr_review.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/auto_pr_review.yaml b/.github/workflows/auto_pr_review.yaml index ff57583348..4585b98244 100644 --- a/.github/workflows/auto_pr_review.yaml +++ b/.github/workflows/auto_pr_review.yaml @@ -46,5 +46,4 @@ jobs: * Before marking as "ready for review", ensure: * the goal is clearly stated in the description * all the tests are passing - * the change is [something we merge](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-gets-merged) * include a route or your device' dongle ID if relevant