From 130692f07206fee7641ff7658a888f63dd08325d Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Fri, 10 Feb 2023 22:10:59 -0800 Subject: [PATCH 1/2] Add friction brake unavailable signal --- generator/gm/gm_global_a_powertrain.dbc | 3 +++ gm_global_a_powertrain_generated.dbc | 3 +++ 2 files changed, 6 insertions(+) diff --git a/generator/gm/gm_global_a_powertrain.dbc b/generator/gm/gm_global_a_powertrain.dbc index e84943ae7a..9aa26c3950 100644 --- a/generator/gm/gm_global_a_powertrain.dbc +++ b/generator/gm/gm_global_a_powertrain.dbc @@ -174,6 +174,9 @@ BO_ 532 BRAKE_RELATED: 6 XXX BO_ 560 EPBStatus: 8 EPB SG_ EPBClosed : 12|1@0+ (1,0) [0|1] "" NEO +BO_ 562 EBCMFrictionBrakeStatus: 8 XXX + SG_ FrictionBrakeUnavailable : 46|1@0+ (1,0) [0|1] "" XXX + BO_ 608 SPEED_RELATED: 8 XXX SG_ RollingCounter : 5|2@0+ (1,0) [0|0] "" XXX SG_ ClusterSpeed : 31|8@0+ (1,0) [0|0] "" XXX diff --git a/gm_global_a_powertrain_generated.dbc b/gm_global_a_powertrain_generated.dbc index 5a19b61fa9..d3affe15a4 100644 --- a/gm_global_a_powertrain_generated.dbc +++ b/gm_global_a_powertrain_generated.dbc @@ -194,6 +194,9 @@ BO_ 532 BRAKE_RELATED: 6 XXX BO_ 560 EPBStatus: 8 EPB SG_ EPBClosed : 12|1@0+ (1,0) [0|1] "" NEO +BO_ 562 EBCMFrictionBrakeStatus: 8 XXX + SG_ FrictionBrakeUnavailable : 46|1@0+ (1,0) [0|1] "" XXX + BO_ 608 SPEED_RELATED: 8 XXX SG_ RollingCounter : 5|2@0+ (1,0) [0|0] "" XXX SG_ ClusterSpeed : 31|8@0+ (1,0) [0|0] "" XXX From 01091dea23f043e93a437445f402d523128f3269 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Fri, 10 Feb 2023 23:41:11 -0800 Subject: [PATCH 2/2] add comment --- generator/gm/gm_global_a_powertrain.dbc | 1 + gm_global_a_powertrain_generated.dbc | 1 + 2 files changed, 2 insertions(+) diff --git a/generator/gm/gm_global_a_powertrain.dbc b/generator/gm/gm_global_a_powertrain.dbc index 9aa26c3950..22acc2f8c8 100644 --- a/generator/gm/gm_global_a_powertrain.dbc +++ b/generator/gm/gm_global_a_powertrain.dbc @@ -294,6 +294,7 @@ CM_ SG_ 190 GasPedalAndAcc "ACC baseline is 62"; CM_ SG_ 352 Ignition "Non-zero when ignition is on"; CM_ SG_ 451 GasPedalAndAcc2 "ACC baseline is 62"; CM_ SG_ 481 ACCAlwaysOne "Usually 1 if the car is equipped with ACC"; +CM_ SG_ 562 FrictionBrakeUnavailable "1 when ACC brake control is unavailable. Stays high if brake command messages are blocked for a period of time"; CM_ SG_ 497 Ignition "Describes ignition + preconditioning mode, noisy"; CM_ SG_ 501 PRNDL2 "When ManualMode is Active, Value is 13=L1 12=L2 11=L3 ... 4=L10"; CM_ SG_ 532 UserBrakePressure "can be lower than other brake position signals when the brakes are pre-filled from ACC braking and the user presses on the brakes. user-only pressure?"; diff --git a/gm_global_a_powertrain_generated.dbc b/gm_global_a_powertrain_generated.dbc index d3affe15a4..916a0a254d 100644 --- a/gm_global_a_powertrain_generated.dbc +++ b/gm_global_a_powertrain_generated.dbc @@ -314,6 +314,7 @@ CM_ SG_ 190 GasPedalAndAcc "ACC baseline is 62"; CM_ SG_ 352 Ignition "Non-zero when ignition is on"; CM_ SG_ 451 GasPedalAndAcc2 "ACC baseline is 62"; CM_ SG_ 481 ACCAlwaysOne "Usually 1 if the car is equipped with ACC"; +CM_ SG_ 562 FrictionBrakeUnavailable "1 when ACC brake control is unavailable. Stays high if brake command messages are blocked for a period of time"; CM_ SG_ 497 Ignition "Describes ignition + preconditioning mode, noisy"; CM_ SG_ 501 PRNDL2 "When ManualMode is Active, Value is 13=L1 12=L2 11=L3 ... 4=L10"; CM_ SG_ 532 UserBrakePressure "can be lower than other brake position signals when the brakes are pre-filled from ACC braking and the user presses on the brakes. user-only pressure?";