Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model replay random failures #23234

Closed
adeebshihadeh opened this issue Dec 15, 2021 · 2 comments · Fixed by #23235
Closed

model replay random failures #23234

adeebshihadeh opened this issue Dec 15, 2021 · 2 comments · Fixed by #23235
Labels

Comments

@adeebshihadeh
Copy link
Contributor

Should be easy to catch running a loop. @deanlee want to take a look at and see why this isn't fully deterministic? There's a chance it's a test bug too.

https://jenkins.comma.life/blue/organizations/jenkins/openpilot/detail/master/1233/pipeline

Logs attached from that failed jenkins run.
log.txt

@deanlee
Copy link
Contributor

deanlee commented Dec 15, 2021

Is it possible that it is caused by the occasional difference in the update order of 'lateralPlan,liveCalibration' and vipc frame in modeld?

for msg in tqdm(lr_list):
if msg.which() == "liveCalibration":
last_calib = list(msg.liveCalibration.rpyCalib)
pm.send(msg.which(), replace_calib(msg, last_calib))
elif msg.which() == "lateralPlan":
last_desire = msg.lateralPlan.desire
elif msg.which() in ["roadCameraState", "driverCameraState"]:
ret = process_frame(msg, pm, sm, log_msgs, vipc_server, spinner, frs, frame_idxs, last_desire)
if ret is None:
break

If this is the case, waiting for a while after send msg, or update live calibration in main thread to ensuring the order of updates in modeld may solve this problem

@adeebshihadeh
Copy link
Contributor Author

hopefully fixed by #23237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants