New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Hyundai features by CAN fingerprint #24127

Closed

sshane opened this issue Apr 5, 2022 · 1 comment

Labels

Contributor

sshane commented Apr 5, 2022 •

edited

Loading

If we can do this reliably via CAN fingerprint, we can get rid of some of these lists:

openpilot/selfdrive/car/hyundai/values.py

Line 1118 in 433f649

FEATURES = {

For example, the car in this PR could be removed and added to the existing Ioniq PHEV: #24089

sshane added the car cleanup label

pd0wm added cleanup car and removed car cleanup labels

Contributor

adeebshihadeh commented Feb 1, 2023

Don't really need an issue for this

adeebshihadeh closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment