Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.16 master-ci oversteering on roads curving towards the right #25369

Closed
ynwng opened this issue Aug 5, 2022 · 7 comments
Closed

0.8.16 master-ci oversteering on roads curving towards the right #25369

ynwng opened this issue Aug 5, 2022 · 7 comments
Labels
bug drivingfb Segments with room for improvement

Comments

@ynwng
Copy link

ynwng commented Aug 5, 2022

Describe the bug

Branch: 0.8.16 master-ci
Car; Toyota Corolla Hatchback 2020

0.8.16 seems to oversteer when the road curves right.

From the route:

  • 19.16.02 - Felt like the car was going to run into the curb.
  • 19:18:11 - Car cutting into the shoulder of the road.
  • 19.19.07 - I also felt like the car was going to run into the curb. There was a warning to take over.
  • 19:19:18 - Car driving into the next lane on the right.

I'm not sure if cutting into the next lane/shoulder is the intended behavior of laneless since I was previously using Shane's fork on 0.8.13 without laneless. To me, switching to master-ci feels less chill and more stressful, since I feel like I can't trust openpilot as much.

Provide a route where the issue occurs

50c35b8d29fd7574|2022-08-04--19-05-32

openpilot version

0.8.16

Additional info

No response

@ynwng ynwng added the bug label Aug 5, 2022
@ynwng
Copy link
Author

ynwng commented Aug 5, 2022

Some more on 50c35b8d29fd7574|2022-08-04--18-20-49

  • 18:26:44 - Starts driving into the right lane
  • 18:29:34 - Drifting off into the shoulder, but maybe an acceptable amount? Did not feel comfortable but laneless is new to me.
  • 18:30:01 - On an offramp, I thought it was going to turn into the curb.

@ynwng
Copy link
Author

ynwng commented Aug 5, 2022

Not sure if I should create a separate issue but I noticed this model driving over the left lane line sometimes too. But not a harsh oversteer like the curves to the right.

50c35b8d29fd7574|2022-08-04--12-20-06--0

  • 12:21:49 - Engaged openpilot and it started driving over the left line. The wheel was past the double yellow lines when looking through the driver side mirror (12:21:52). When it started getting close to the median and the pole, I tugged the wheel to the right just to be safe I wouldn't hit it, but didn't disengage (12:21:58).
  • 12:22:53 - Driving over the double yellow line to the left. You can see me tug the wheel back to the right at 12:22:55.

@ynwng
Copy link
Author

ynwng commented Aug 7, 2022

Some more segments before I switch back to Shane's fork on 0.8.13. All of the timestamps below were handled fine by 0.8.13 though.

  • 50c35b8d29fd7574|2022-08-06--18-28-00--2 (18:30:41) - Driving on the lane line for a right bend, which was not ideal for the car next to me which slowed down thinking I was trying to change lanes and taking awhile to do so.
  • 50c35b8d29fd7574|2022-08-06--18-53-45--5 (18:59:34) - Already have a different clip of this, but 0.8.16 cannot stay in lane, it drives in the middle of two lanes for this bend.
  • 50c35b8d29fd7574|2022-08-06--19-45-28--1 (19:47:01) - Would have hit the car parked on the shoulder if I didn't disengage.
  • 50c35b8d29fd7574|2022-08-06--19-45-28--4 (19:49:41) - Not the issue of the right lane but driving on the double yellow does not feel safe.
  • 50c35b8d29fd7574|2022-08-06--20-38-02--1 (20:39:21) - Would have hit the cones but I tugged the wheel left.
  • 50c35b8d29fd7574|2022-08-06--20-38-02--5 (20:42:55) - Went way out in the shoulder on a right bend, as if the shoulder was part of the lane.

@adeebshihadeh adeebshihadeh added the drivingfb Segments with room for improvement label Aug 8, 2022
@haraschax
Copy link
Contributor

The model does oversteer in tighter turns sometimes. We are looking into this and trying to fix it. Thanks for the detailed feedback!!

@haraschax
Copy link
Contributor

#25413

Hopefully this improves your experience

@ynwng
Copy link
Author

ynwng commented Aug 19, 2022

Hey Harald, I've been running the falcon punch model for a few days now and the right oversteering is much better. It will still sometimes drive over the right lane on right bends, but less harshly and I guess that's to be expected out of laneless. This issue seems closeable on my end. I did run into a new bug, but I'll create a separate issue for that.

@ynwng
Copy link
Author

ynwng commented Aug 19, 2022

The separate issue that I created #25487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug drivingfb Segments with room for improvement
Projects
None yet
Development

No branches or pull requests

3 participants