Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma 3. Car Unrecognized msg. Toyota Camry Hybrid 2021 (Thailand) #30164

Closed
dwerty3 opened this issue Oct 4, 2023 · 5 comments
Closed

Comma 3. Car Unrecognized msg. Toyota Camry Hybrid 2021 (Thailand) #30164

dwerty3 opened this issue Oct 4, 2023 · 5 comments
Labels
car vehicle-specific fingerprint toyota

Comments

@dwerty3
Copy link

dwerty3 commented Oct 4, 2023 •
edited
Loading

Describe the bug

Hello.
I bought new Comma 3, install it but it showed messages after start:

  1. Openpilot was unable to identify your car. Your car is either unsupported or ECUs are not recognized. Please submit a pull request to add the firmware version to the proper vehicle. Need support? Join discourd.comma.ai.
  2. Unsupported car.
  3. Car Unrecognized.

Also driver camera preview button didn't work and showed "Starting camera" only and nothing more.

I read fingerprint manual then add my car fingerprint to values.py and reinstall from https://installer.comma.ai/dwerty3/master

**Fingerprint from "carParams" log:** 
           'carFw': [{'address': 1968,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'abs',
                      'fwVersion': b'F152633214\x00\x00\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1976,
                      'subAddress': 0},
                     {'address': 1937,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'dsu',
                      'fwVersion': b'8821F0609100    ',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1945,
                      'subAddress': 0},
                     {'address': 1920,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'srs',
                      'fwVersion': b'8917F06420\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1928,
                      'subAddress': 0},
                     {'address': 1924,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'srs',
                      'fwVersion': b'8917F06420\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1932,
                      'subAddress': 0},
                     {'address': 1953,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'eps',
                      'fwVersion': b'8965B33621\x00\x00\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1961,
                      'subAddress': 0},
                     {'address': 1988,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'hvac',
                      'fwVersion': b'8865F3301101    ',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1996,
                      'subAddress': 0},
                     {'address': 1792,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'engine',
                      'fwVersion': b'\x018966306L9000\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1800,
                      'subAddress': 0},
                     {'address': 2002,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'hybrid',
                      'fwVersion': b'\x02899833325100\x00\x00\x00\x00899853310000\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 2010,
                      'subAddress': 0},
                     {'address': 1984,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'combinationMeter',
                      'fwVersion': b'\x03838000XF3128\x00\x00\x00\x00838000XF3222\x00\x00\x00\x00838000XF3322\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1992,
                      'subAddress': 0},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'fwdRadar',
                      'fwVersion': b'8821F0609100    ',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1880,
                      'subAddress': 15},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'fwdCamera',
                      'fwVersion': b'8646F0601400    ',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1880,
                      'subAddress': 109},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'epb',
                      'fwVersion': b'895DF33010\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1880,
                      'subAddress': 44}],
**New fingerprint in values.py** 
  CAR.CAMRYH_TSS2: {
    (Ecu.eps, 0x7a1, None): [
      b'8965B33621\x00\x00\x00\x00\x00\x00', # notice that the firmware from car params is added here.
      b'8965B33630\x00\x00\x00\x00\x00\x00',
      b'8965B33650\x00\x00\x00\x00\x00\x00',
    ],
    (Ecu.abs, 0x7b0, None): [
      b'F152633D00\x00\x00\x00\x00\x00\x00',
      b'F152633D60\x00\x00\x00\x00\x00\x00',
      b'F152633214\x00\x00\x00\x00\x00\x00', # notice that the firmware from car params is added here.
      b'F152633310\x00\x00\x00\x00\x00\x00',
    ],
    (Ecu.engine, 0x700, None): [
      b'\x018966306Q6000\x00\x00\x00\x00',
      b'\x018966306Q7000\x00\x00\x00\x00',
      b'\x018966306T0000\x00\x00\x00\x00',
      b'\x018966306V1000\x00\x00\x00\x00',
      b'\x018966306L9000\x00\x00\x00\x00', #notice that the firmware from car params is added here.
      b'\x01896633T20000\x00\x00\x00\x00',
    ],
    (Ecu.fwdRadar, 0x750, 15): [
      b'\x018821F6201200\x00\x00\x00\x00',
      b'\x018821F6201300\x00\x00\x00\x00',
      b'\x018821F6201400\x00\x00\x00\x00',
      b'8821F0609100    ', #notice that the firmware from car params is added here.
    ],
    (Ecu.fwdCamera, 0x750, 109): [
      b'\x028646F3305200\x00\x00\x00\x008646G5301200\x00\x00\x00\x00',
      b'\x028646F3305300\x00\x00\x00\x008646G5301200\x00\x00\x00\x00',
      b'\x028646F3305300\x00\x00\x00\x008646G3304000\x00\x00\x00\x00',
      b'\x028646F3305500\x00\x00\x00\x008646G3304000\x00\x00\x00\x00',
      b'8646F0601400    ', #notice that the firmware from car params is added here.
    ],
  # START. notice that the firmware from car params is added here.
    (Ecu.dsu, 0x791, None): [
      b'8821F0609100    ',
    ],
    (Ecu.srs, 0x780, None): [
      b'8917F06420\x00\x00\x00\x00\x00\x00',
    ],
    (Ecu.srs, 0x784, None): [
      b'8917F06420\x00\x00\x00\x00\x00\x00',
    ],
    (Ecu.hvac, 0x7C4, None): [
      b'8865F3301101    ',
    ],
    (Ecu.hybrid, 0x7D2, None): [
      b'\x02899833325100\x00\x00\x00\x00899853310000\x00\x00\x00\x00',
    ],
    (Ecu.combinationMeter, 0x7C0, None): [
      b'\x03838000XF3128\x00\x00\x00\x00838000XF3222\x00\x00\x00\x00838000XF3322\x00\x00\x00\x00',
    ],
    (Ecu.epb, 0x750, 44): [
      b'895DF33010\x00\x00\x00\x00\x00\x00',
    ],    
  # END. notice that the firmware from car params is added here.

All of this doesn't help.

Which car does this affect?

Toyota Camry Hybrid 2021 (Thailand)

Provide a route where the issue occurs

2ed432126627c66a|2023-10-04--14-14-04

openpilot version

0.9.5 master

Additional info

I tried many times to reinstall and change parameters again but can't fix it. Spent already 18 months. Hope you can help me to fix it.

Photos

20231004_211616.jpg

![20231004_211632.jpg](https://github.![20231004_211623.jpg](https://github.com/commaai/openpilot/assets/106430863/437d5733-eedb-4408-b172-1979692339a6)

20231004_015331.jpg

20231004_015322.jpg

20231004_211623.jpg

20231004_211632.jpg

20231004_015331.jpg

20231004_015537.jpg
@dwerty3 dwerty3 added bug car vehicle-specific labels Oct 4, 2023
@jnewb1 jnewb1 added the toyota label Oct 4, 2023
@sshane
Copy link
Contributor

sshane commented Oct 4, 2023

Your local model year might be 2021, but to openpilot it's a TSS-P Camry Hybrid so you had it in the wrong platform. Can you open a PR to add it to CAMRYH platform? If not just let me know. FYI #28641 catches this

@sshane sshane added fingerprint and removed bug labels Oct 4, 2023
@dwerty3
Copy link
Author

dwerty3 commented Oct 5, 2023

Can you open a PR to add it to CAMRYH platform? If not just let me know. FYI

  • Thank you for answer. Sorry, but I don't know how to do this. Could you explain?

@sshane
Copy link
Contributor

sshane commented Oct 5, 2023 •
edited
Loading

I added your missing engine FW to master in #30177. Please try master-ci or nightly until the next release!

https://installer.comma.ai/commaai/nightly

@sshane sshane closed this as completed Oct 5, 2023
@dwerty3
Copy link
Author

dwerty3 commented Oct 12, 2023 •
edited
Loading

I added your missing engine FW to master in #30177. Please try master-ci or nightly until the next release!

Hello, @sshane.

I updated it to openpilot nightly (12 Oct) but comma still show Camera Malfunction.

Could you check it?

Photos

20231012_211333.jpg

20231012_210905.jpg

20231012_210938.jpg

Driver camera preview show this only:
20231012_210946.jpg

@sshane
Copy link
Contributor

sshane commented Oct 12, 2023

You should contact support at https://comma.ai/support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
car vehicle-specific fingerprint toyota
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jnewb1 @sshane @dwerty3