Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexus IS500 - Not Recognized #30723

Closed
MISTERgadget opened this issue Dec 14, 2023 · 1 comment · Fixed by #31729
Closed

Lexus IS500 - Not Recognized #30723

MISTERgadget opened this issue Dec 14, 2023 · 1 comment · Fixed by #31729
Labels
bug car vehicle-specific

Comments

@MISTERgadget
Copy link

Describe the bug

Receiving car unsupported message, although 2022-23 Lexus IS is noted as supported. Started trying to fingerprint vehicle, however unsure if having 2 ECUs sharing the same name (srs) would cause issues.

Which car does this affect?

2023 Lexus IS500

Provide a route where the issue occurs

9bf4af979ddee563|2023-12-14--01-14-09

openpilot version

0.9.5

Additional info

See carFw data below

           'carFw': [{'address': 1920,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'srs',
                      'fwVersion': b'8917F53470\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1928,
                      'subAddress': 0},
                     {'address': 1924,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'srs',
                      'fwVersion': b'8917F53470\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1932,
                      'subAddress': 0},
                     {'address': 1984,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'combinationMeter',
                      'fwVersion': b'8380053N9202    ',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1992,
                      'subAddress': 0},
                     {'address': 1953,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'eps',
                      'fwVersion': b'8965B53800\x00\x00\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1961,
                      'subAddress': 0},
                     {'address': 1988,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'hvac',
                      'fwVersion': b'8865053A5201    ',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\x1a\x88\x01'],
                      'responseAddress': 1996,
                      'subAddress': 0},
                     {'address': 2017,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'transmission',
                      'fwVersion': b'\x01895365317000\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\t\x04'],
                      'responseAddress': 2025,
                      'subAddress': 0},
                     {'address': 2016,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'engine',
                      'fwVersion': b'\x02353U0000\x00\x00\x00\x00\x00\x00\x00\x0052422000\x00\x00\x00\x00\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>', b'\t\x04'],
                      'responseAddress': 2024,
                      'subAddress': 0},
                     {'address': 1968,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'abs',
                      'fwVersion': b'\x01F15265343000\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1976,
                      'subAddress': 0},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'fwdRadar',
                      'fwVersion': b'\x018821F6201400\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1880,
                      'subAddress': 15},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'fwdCamera',
                      'fwVersion': b'\x028646F5303400\x00\x00\x00\x008646G3304000\x00\x00\x00\x00',
                      'logging': False,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1880,
                      'subAddress': 109},
                     {'address': 1872,
                      'brand': 'toyota',
                      'bus': 0,
                      'ecu': 'telematics',
                      'fwVersion': b'\x03FDC40.48.16\x00\x00\x00\x00\x00FDC40.58.16\x00\x00\x00\x00\x00132.0.4e00\x00\x00\x00\x00\x00\x00',
                      'logging': True,
                      'obdMultiplexing': True,
                      'request': [b'>\x00', b'\x10\x01', b'\x10\x03', b'"\xf1\x81'],
                      'responseAddress': 1880,
                      'subAddress': 199}],
           'carName': 'mock',
           'carVin': 'JTHAP1D26P5004244',
@MISTERgadget MISTERgadget added bug car vehicle-specific labels Dec 14, 2023
@MISTERgadget
Copy link
Author

I tried fingerprinting the car myself and adding it, but getting errors. Was unsure if it needs to be a separate line item or if the ECUs should be added to an existing car.

Here is where I added it, lines 1216-1250

https://github.com/MISTERgadget/openpilot/blob/master/selfdrive/car/toyota/values.py
IMG_4569

@sshane sshane linked a pull request Mar 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant