From 9b37faba4e2c4506d60a2adf76485e5a5a57088d Mon Sep 17 00:00:00 2001 From: Jason Young Date: Wed, 18 Sep 2024 14:48:16 -0400 Subject: [PATCH 1/8] car_specific support for FCA Giorgio --- selfdrive/car/car_specific.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/selfdrive/car/car_specific.py b/selfdrive/car/car_specific.py index 94afec50e2a390..1e5af6e8e697d4 100644 --- a/selfdrive/car/car_specific.py +++ b/selfdrive/car/car_specific.py @@ -158,6 +158,9 @@ def update(self, CS: car.CarState, CS_prev: car.CarState, CC: car.CarControl): if self.low_speed_alert: events.add(EventName.belowSteerSpeed) + elif self.CP.carName == 'fca_giorgio': + events = self.create_common_events(CS.out, CS_prev) + else: raise ValueError(f"Unsupported car: {self.CP.carName}") From 14e7ba4b655ddb458781cbe3c7be4f789cfb666f Mon Sep 17 00:00:00 2001 From: Jason Young Date: Wed, 18 Sep 2024 14:49:37 -0400 Subject: [PATCH 2/8] force fingerprint -- revert before merge --- launch_env.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/launch_env.sh b/launch_env.sh index 1e5bc7b607cc37..120542b0368d9e 100755 --- a/launch_env.sh +++ b/launch_env.sh @@ -11,3 +11,5 @@ if [ -z "$AGNOS_VERSION" ]; then fi export STAGING_ROOT="/data/safe_staging" + +export FINGERPRINT="ALFA_ROMEO_STELVIO_1ST_GEN" From 3bfc28fe7ac4ccd9de0bb101d52834cfc0bebcd4 Mon Sep 17 00:00:00 2001 From: Jason Young Date: Wed, 18 Sep 2024 15:23:15 -0400 Subject: [PATCH 3/8] temp disable process_replay for FCA Giorgio --- selfdrive/test/process_replay/test_processes.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/selfdrive/test/process_replay/test_processes.py b/selfdrive/test/process_replay/test_processes.py index ec84f37d1f7197..d626b686555b79 100755 --- a/selfdrive/test/process_replay/test_processes.py +++ b/selfdrive/test/process_replay/test_processes.py @@ -60,7 +60,8 @@ ] # dashcamOnly makes don't need to be tested until a full port is done -excluded_interfaces = ["mock", "tesla"] +# FIXME: Revert before merging, need a process_replay test route for fca_giorgio +excluded_interfaces = ["mock", "tesla", "fca_giorgio"] BASE_URL = "https://commadataci.blob.core.windows.net/openpilotci/" REF_COMMIT_FN = os.path.join(PROC_REPLAY_DIR, "ref_commit") From f9431bba248ee20e8ba40f700afbc1e5a8e53a30 Mon Sep 17 00:00:00 2001 From: Jason Young Date: Wed, 18 Sep 2024 15:26:22 -0400 Subject: [PATCH 4/8] regen CARS.md --- docs/CARS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/CARS.md b/docs/CARS.md index 44c9327378fe92..f2ea7af7238916 100644 --- a/docs/CARS.md +++ b/docs/CARS.md @@ -4,13 +4,14 @@ A supported vehicle is one that just works when you install a comma device. All supported cars provide a better experience than any stock system. Supported vehicles reference the US market unless otherwise specified. -# 289 Supported Cars +# 290 Supported Cars |Make|Model|Supported Package|ACC|No ACC accel below|No ALC below|Steering Torque|Resume from stop|Hardware Needed
 |Video| |---|---|---|:---:|:---:|:---:|:---:|:---:|:---:|:---:| |Acura|ILX 2016-19|AcuraWatch Plus|openpilot|26 mph|25 mph|[![star](assets/icon-star-empty.svg)](##)|[![star](assets/icon-star-empty.svg)](##)|
Parts- 1 Honda Nidec connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| |Acura|RDX 2016-18|AcuraWatch Plus|openpilot|26 mph|12 mph|[![star](assets/icon-star-empty.svg)](##)|[![star](assets/icon-star-empty.svg)](##)|
Parts- 1 Honda Nidec connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| |Acura|RDX 2019-22|All|openpilot available[1](#footnotes)|0 mph|3 mph|[![star](assets/icon-star-empty.svg)](##)|[![star](assets/icon-star-full.svg)](##)|
Parts- 1 Honda Bosch A connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| +|Alfa|Romeo Stelvio 2017-24|Adaptive Cruise Control (ACC) & Lane Assist|Stock|0 mph|0 mph|[![star](assets/icon-star-full.svg)](##)|[![star](assets/icon-star-full.svg)](##)|
Parts- 1 RJ45 cable (7 ft)
- 1 VW A connector
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| |Audi|A3 2014-19|Adaptive Cruise Control (ACC) & Lane Assist|openpilot available[1,12](#footnotes)|0 mph|0 mph|[![star](assets/icon-star-full.svg)](##)|[![star](assets/icon-star-full.svg)](##)|
Parts- 1 USB-C coupler
- 1 VW J533 connector
- 1 comma 3X
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| |Audi|A3 Sportback e-tron 2017-18|Adaptive Cruise Control (ACC) & Lane Assist|openpilot available[1,12](#footnotes)|0 mph|0 mph|[![star](assets/icon-star-full.svg)](##)|[![star](assets/icon-star-full.svg)](##)|
Parts- 1 USB-C coupler
- 1 VW J533 connector
- 1 comma 3X
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| |Audi|Q2 2018|Adaptive Cruise Control (ACC) & Lane Assist|openpilot available[1,12](#footnotes)|0 mph|0 mph|[![star](assets/icon-star-full.svg)](##)|[![star](assets/icon-star-full.svg)](##)|
Parts- 1 USB-C coupler
- 1 VW J533 connector
- 1 comma 3X
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|| From d499eb5e9cfc3c9e9a85f71652ddab9b1ef5e20d Mon Sep 17 00:00:00 2001 From: Jason Young Date: Thu, 19 Sep 2024 12:24:55 -0400 Subject: [PATCH 5/8] bump opendbc --- opendbc_repo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opendbc_repo b/opendbc_repo index c4114772ba9d77..c6311eed8a1dc9 160000 --- a/opendbc_repo +++ b/opendbc_repo @@ -1 +1 @@ -Subproject commit c4114772ba9d77bf03b97972611591e0bf8e4a25 +Subproject commit c6311eed8a1dc910c645e3425dd43e7434472c10 From 540730b8b689e397f70559f90bff95a62ab66b0e Mon Sep 17 00:00:00 2001 From: Jason Young Date: Thu, 19 Sep 2024 12:25:15 -0400 Subject: [PATCH 6/8] bump panda --- panda | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/panda b/panda index 0b364ece1eafa2..ef3f4e7476ae58 160000 --- a/panda +++ b/panda @@ -1 +1 @@ -Subproject commit 0b364ece1eafa2e66b71be7cade3fdfb56a3014e +Subproject commit ef3f4e7476ae586c801afba73a0e9bc51dfeeaec From 4233b60db64476282b45ed4512601b79a89920af Mon Sep 17 00:00:00 2001 From: Jason Young Date: Sat, 21 Sep 2024 12:56:07 -0400 Subject: [PATCH 7/8] note this should be reverted --- launch_env.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/launch_env.sh b/launch_env.sh index 120542b0368d9e..904f4180df29b8 100755 --- a/launch_env.sh +++ b/launch_env.sh @@ -12,4 +12,5 @@ fi export STAGING_ROOT="/data/safe_staging" +# FIXME: revert once UDS/VIN fingerprinting in place export FINGERPRINT="ALFA_ROMEO_STELVIO_1ST_GEN" From 4b73eeb45f2e629b2d310fbf8fd8f671de70a096 Mon Sep 17 00:00:00 2001 From: Jason Young Date: Sat, 21 Sep 2024 12:56:13 -0400 Subject: [PATCH 8/8] note this should be refactored --- selfdrive/car/car_specific.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/selfdrive/car/car_specific.py b/selfdrive/car/car_specific.py index 1e5af6e8e697d4..a9c9021577fd6e 100644 --- a/selfdrive/car/car_specific.py +++ b/selfdrive/car/car_specific.py @@ -158,6 +158,8 @@ def update(self, CS: car.CarState, CS_prev: car.CarState, CC: car.CarControl): if self.low_speed_alert: events.add(EventName.belowSteerSpeed) + # TODO: Shouldn't be necessary. Refactor CarSpecificEvents with a simple default case, override only if necessary. + # Default case should cover FCA Giorgio, Subaru, Mazda, maybe Ford. Further simplification possible. elif self.CP.carName == 'fca_giorgio': events = self.create_common_events(CS.out, CS_prev)