Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K-Line/L-Line baud rate 2x too high #1548

Closed
pd0wm opened this issue Aug 3, 2023 · 1 comment · Fixed by #1588
Closed

K-Line/L-Line baud rate 2x too high #1548

pd0wm opened this issue Aug 3, 2023 · 1 comment · Fixed by #1588

Comments

@pd0wm
Copy link
Contributor

pd0wm commented Aug 3, 2023

Noticed the K-Line and L-Line baud rate is 2x too high on a white panda. It should be 10400, but looks like double that on the scope. (see baud rate init code: https://github.com/commaai/panda/blob/master/board/main.c#L383).

uart_set_baud is probably assuming the wrong APB/clock to compute the register settings for UART5 and USART3. https://github.com/commaai/panda/blob/master/board/stm32fx/lluart.h#L191

Unfortunately #1343 makes it a bit annoying to test a fix. It's on my list to take a stab at that.

ScreenImg
@briskspirit
Copy link
Contributor

https://github.com/commaai/panda/blob/95c89b8045e9a5731879ae87340f4cd4af7efa20/board/stm32fx/lluart.h#L93C24-L93C33

24000000U needs to be changed to APB1_FREQ .

@briskspirit briskspirit mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

F4: fix UART clocks commaai/panda
2 participants
@pd0wm @briskspirit