Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color theme support #22

Merged
merged 16 commits into from
Feb 9, 2023
Merged

Conversation

EmilyGraceSeville7cf
Copy link
Member

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Feb 7, 2023

closes #15

60 color settings available (use bash ./clip-view.sh -h | grep '\$' | wc -l to check):

image

Notes

-cc|--clear-cache flag is replaced with -cpc|--clear-page-cache.

@EmilyGraceSeville7cf EmilyGraceSeville7cf added the enhancement New feature or request label Feb 7, 2023
@EmilyGraceSeville7cf EmilyGraceSeville7cf self-assigned this Feb 7, 2023
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft February 7, 2023 18:30
@EmilyGraceSeville7cf
Copy link
Member Author

EmilyGraceSeville7cf commented Feb 7, 2023

image

@blueglyph, here is how to use color themes. :) default theme is located here. After first usage any color theme is cached and reused until it's requested explicitly to refresh it. The same applies for all CLIP pages. yq is used for parsing yaml files.

How to get intellisence? Install this Red Hat VS Code extension or anything like that if another editor is used. Then change VS Code settings like this:

{
    "yaml.schemas": {
        "path/to/theme.json": "path/to/file_where_to_enable_intellisence.yaml"
    }
}

The first file was put here. Download it locally and write path to it. Personally I don't like such manual intellisence setup and I guess we can provide some default color schema (rename it to make it's name more unique, for instance to clip-view-default-color-theme.yaml) and mention it in SchemaStore to automatically be used when default theme config is opened.

@hyperupcall, wdyt about including my JSON schema for this project in SchemaStore repo like a link to this .json?

@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review February 7, 2023 20:42
@hyperupcall
Copy link

@EmilySeville7cfg SchemaStore has a requirement that schemas must have some minimal level of popularity - I don't think personal schemas as these meet that requirement?

@EmilyGraceSeville7cf
Copy link
Member Author

@EmilySeville7cfg SchemaStore has a requirement that schemas must have some minimal level of popularity - I don't think personal schemas as these meet that requirement?

In other words, how many project stars should I have in your opinion?

@hyperupcall
Copy link

hyperupcall commented Feb 8, 2023

@EmilySeville7cfg My personal limit when adding schemas for other repositories is a thousand stars - there is always a risk of the project not working out and needing to remove the stale schema. If somebody else chooses to write the schema, then I guess the bar doesn't have to be as high - say a few hundred or so stars, but the point is that there are a more than a few dozen people benefiting from the schema and that each schema is from some community where people would at least recognize the project.

@EmilyGraceSeville7cf EmilyGraceSeville7cf merged commit ea3e151 into main Feb 9, 2023
@navarroaxel navarroaxel deleted the feature/theme-support-for-render branch February 9, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create JSON schema for color schemas and add support for coloring from specific theme files
2 participants