Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is needed to fix: commanded/commanded#401
TODO
subscribe
from adisconnected
statecheckpoint_last_seen
ornotify_subscribers
probably needs to be changed as wellI guess a
transient
subscription can never get in adisconnected
state, because theAdvisoryLocks
are only used for saved subscriptions.In theory
checkpoint_last_seen
doesn't need to be changed, because the update statement will not fail, but changed it as well so we don't even try to update.To discuss
Because we don't store anything, it's possible to:
I think this is logical, but it might surprise some users, so I'll add it to the documentation.