Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotfiles in test dir cause a panic #204

Open
taigrr opened this issue Nov 2, 2023 · 1 comment · May be fixed by #205
Open

dotfiles in test dir cause a panic #204

taigrr opened this issue Nov 2, 2023 · 1 comment · May be fixed by #205

Comments

@taigrr
Copy link
Contributor

taigrr commented Nov 2, 2023

Prerequisites

  • [X ] Can you reproduce the problem?
  • [X ] Are you running the latest version?
  • [X ] Did you perform a cursory search?

Description

Using latest release on macos, the --dir tests cause the binary to panic because a non-yaml file, .DS_Store, exists in the directory. This also happens if there's a .gitignore or .gitattributes file present.

Steps to Reproduce

  1. Create a testing dir
  2. add a non-yaml dotfile to the directory
  3. test using --dir
  4. observe the binary panic

Expected behavior: the binary should skip hidden files

Actual behavior: the binary does not skip hidden files, and panics

Specifications

  • Version: 2.5.0
  • Platform: All
@taigrr taigrr linked a pull request Nov 2, 2023 that will close this issue
Open
4 tasks
@taigrr
Copy link
Contributor Author

taigrr commented Nov 2, 2023

thanks to @jscottsf for pointing out this bug to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skip hidden files in --dir folder taigrr/commander
1 participant
@taigrr