Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack build --pedantic shouldn't apply to packages marked extra-dep #1272

Closed
mboes opened this issue Nov 3, 2015 · 1 comment
Closed

stack build --pedantic shouldn't apply to packages marked extra-dep #1272

mboes opened this issue Nov 3, 2015 · 1 comment

Comments

@mboes
Copy link
Contributor

mboes commented Nov 3, 2015

Create a new project with stack new blah simple. Then unpack any odd package from Hackage with compiler warnings into vendor/foo, and make your project depend on it:

resolver: lts-3.11

packages:
- '.'
- location: vendor/foo
  extra-dep: true

Now compile everything with stack build --pedantic. The build will fail due to a compiler warning in foo. I would argue that since foo is a vendor package that the programmer has little control over, --pedantic shouldn't apply to any package marked with extra-dep: true.

@borsboom
Copy link
Contributor

borsboom commented Nov 3, 2015

#1265 will have this effect, since extra-deps will be treated like snapshot packages and won't have command-line GHC flags applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants