Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haddock to travis CI #1623

Closed
mgsloan opened this issue Jan 8, 2016 · 2 comments
Closed

Add haddock to travis CI #1623

mgsloan opened this issue Jan 8, 2016 · 2 comments
Milestone

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Jan 8, 2016

I attempted to add haddock to CI, in this commit, however, the failure doesn't cause the test to fail: https://travis-ci.org/commercialhaskell/stack/jobs/100989663#L1035

I'm guessing this is a bug with cabal haddock, where it doesn't return a failing exit code. I haven't yet tried locally with cabal. stack haddock does yield an exit code when haddock fails.

@mgsloan mgsloan added this to the P2: Should milestone Jan 8, 2016
@borsboom
Copy link
Contributor

borsboom commented Jan 8, 2016

Why not add --haddock --no-haddock-deps to the stack test step instead of doing cabal haddock?

@mgsloan
Copy link
Contributor Author

mgsloan commented Jan 8, 2016

Ahah, good point!

@mgsloan mgsloan closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants