Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading hackage index cache for extra-deps which are already installed? #2081

Closed
mgsloan opened this issue Apr 29, 2016 · 1 comment
Closed

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Apr 29, 2016

This may have some relation to #2070 - the ability to ensure that we are always using the same cabal file.

As discussed here, it extra-deps cause the hackage cache to get loaded, as we need to get their cabal description. I haven't thought through all the details, but this doesn't seem necessary. The fix may be complicated, though:

There are two spots that need the cabal file:

p <- liftIO $ loadPackage ctx name version flags

package <- liftIO $ loadPackage ctx name version flags

In the case that we already have this package installed, there should be enough info in the package db, potentially even in ghc-pkg queries stack already made, to not need to load the cache.

We're going to be swapping out binary with faster serialization soon, so it may be that soon there won't be as much motivation for doing something sophisticated to avoid this 0.3s load time.

@snoyberg
Copy link
Contributor

This is no longer relevant with Pantry, which stores these files in a quickly accessible SQLite database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants