Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend warnings with "Warning:" outside verbose mode so they're not taken as errors #2470

Closed
Blaisorblade opened this issue Aug 10, 2016 · 4 comments

Comments

@Blaisorblade
Copy link
Collaborator

Here's this happening:
#2175 (comment)

Since users all over the world confuse warnings with errors, I assume this is more widespread.
OTOH, I'm not sure how to change this non-invasively :-(.

@Blaisorblade
Copy link
Collaborator Author

BTW: @KeeperB5, would this idea have avoided confusing you?

@lehtoj
Copy link

lehtoj commented Aug 10, 2016

Adding Info, Warning and Error prefixes to messages would certainly go a long way informing user what's what. But on the other hand, would it have a side-effect where proper bugs remain ignored because they're merely warnings?

@mgsloan
Copy link
Contributor

mgsloan commented Aug 12, 2016

Some warnings and errors already do prepending, so it's a little tricky to modify the utilities directly. However, the new pretty print stuff does add some functions like prettyWarning / prettyError / etc. I think it makes sense to add prefixing to these utils and move as much of our warning / error logging to pretty printing as possible.

@mpilgrem
Copy link
Member

mpilgrem commented Mar 1, 2024

I am going to close this issue given the passage of time and the developments over time in Stack's reporting. If specific issues remain, they can be identified and dealt with individually.

@mpilgrem mpilgrem closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants