Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array of integers and floats as command argument parameters #2037

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Aug 29, 2024

It fixes #2034 by considering the case of arrays of integers and floating point numbers.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (6d8c2a4) to head (ef396ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
+ Coverage   83.78%   83.80%   +0.02%     
==========================================
  Files          46       46              
  Lines        8262     8267       +5     
  Branches     2199     2201       +2     
==========================================
+ Hits         6922     6928       +6     
- Misses        858      859       +1     
+ Partials      482      480       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cwltool/argparser.py Outdated Show resolved Hide resolved
@tom-tan
Copy link
Member Author

tom-tan commented Aug 29, 2024

I added tests for int[], long[], float[] and double[].

tests/test_toolargparse.py Outdated Show resolved Hide resolved
tom-tan and others added 2 commits August 29, 2024 11:58
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mr-c mr-c merged commit 2621312 into main Sep 9, 2024
46 checks passed
@mr-c mr-c deleted the int-array-argparser branch September 9, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We cannot pass an array of integers as a command line argument.
2 participants