Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Last" on the Explore page gives ISE #270

Closed
tfmorris opened this issue Jul 16, 2020 · 4 comments
Closed

Clicking "Last" on the Explore page gives ISE #270

tfmorris opened this issue Jul 16, 2020 · 4 comments

Comments

@tfmorris
Copy link

The URL that it goes to is https://view.commonwl.org/workflows?page=1982&size=10
changing this to https://view.commonwl.org/workflows?page=1982&size=1 correctly renders a page with a single entry.

p.s. it's cute how Error: An internal server error occurred is followed by "If this error was unexpected...". I'd suggest that logging Internal Server Errors might be useful. They rarely are expected or anything good.

@stain
Copy link
Member

stain commented Oct 22, 2020

It is caused by error:

spring_1  | 2020-10-22 13:20:08.142 ERROR 1 --- [nio-8080-exec-2] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.springframework.data.mongodb.UncategorizedMongoDbException: Query failed with error code 96 and error message 'Executor error during find command: OperationFailed: Sort operation used more than the maximum 33554432 bytes of RAM. Add an index, or specify a smaller limit.' on server mongo:27017; nested exception is com.mongodb.MongoQueryException: Query failed with error code 96 and error message 'Executor error during find command: OperationFailed: Sort operation used more than the maximum 33554432 bytes of RAM. Add an index, or specify a smaller limit.' on server mongo:27017] with root cause

Happening from this controller:

https://github.com/common-workflow-language/cwlviewer/blob/main/src/main/java/org/commonwl/view/workflow/WorkflowController.java#L94

calling

https://github.com/common-workflow-language/cwlviewer/blob/main/src/main/java/org/commonwl/view/workflow/WorkflowService.java#L97

Workaround added to production instance:

mongo --eval 'db.workflow.createIndex({ retrievedOn: 1})'

@stain stain closed this as completed in 922b434 Oct 22, 2020
@stain
Copy link
Member

stain commented Oct 22, 2020

@stain stain reopened this Oct 22, 2020
@stain
Copy link
Member

stain commented Nov 2, 2020

To test this would need to import all the old content:

https://github.com/common-workflow-language/cwlviewer/blob/main/dump.sh can dump a JSON file of all workflows from the production instance https://view.commonwl.org/

https://github.com/common-workflow-language/cwlviewer/blob/main/load.py can process your JSON file to refresh a new instance - you can use that as starting point for picking up fields

@mr-c
Copy link
Member

mr-c commented Mar 16, 2021

Seems to be fixed!

@mr-c mr-c closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants