Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cwltool version to something from 2021 #306

Closed
mr-c opened this issue Mar 31, 2021 · 8 comments · May be fixed by #345
Closed

Upgrade cwltool version to something from 2021 #306

mr-c opened this issue Mar 31, 2021 · 8 comments · May be fixed by #345

Comments

@mr-c
Copy link
Member

mr-c commented Mar 31, 2021

Currently the container being used seems to be stuck in 2018 (!!)

Verified with cwltool version 1.0.20180525185854

@oceenachi
Copy link

I built a new docker image that upgraded the cwltool to version 3.0 and started a docker container with it. I tested a random URL from https://view.commonwl.org/workflows and was able to parse the workflow from my local without encountering any problem.

Attached here is a screenshot of the parsed workflow
image

@mr-c
Copy link
Member Author

mr-c commented Apr 9, 2021 via email

@oceenachi
Copy link

oceenachi commented Apr 9, 2021

OKay. Do I run this?

@mr-c
Copy link
Member Author

mr-c commented Apr 10, 2021

OKay. Do I run this?

I think you have done everything you need to.

One of the other team members should run that command ( or fix our continuous integration to do it for us)

@oceenachi
Copy link

Okay great. I guess I'll pick another ticket then.

@obasekiosa
Copy link
Contributor

After looking into this I think the issue is that production uses the docker image rather than the master branch of the codebase.
Hence it is stuck on that version.
If every time a merge is done on the master branch the code isn't rebuilt and deployed as prod then even changes being added won't be seen in - As is the current case(Merged PR don't show up on prod).

Right now only the test pipeline gets run on GitHub but it never actually gets updated in prod.

I believe to solve this issue the docker-compose file has to be set to build rather than an image on the docker hub
or there should be a pipeline that updates the docker hub image as soon as the master branch is updated.

@mr-c
Copy link
Member Author

mr-c commented Jul 28, 2021

@cure What's the status on improving the deployment of CWL viewer?

@mr-c
Copy link
Member Author

mr-c commented Sep 30, 2022

This was done

@mr-c mr-c closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants