Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a better page for users when we fail to parse the workflow #397

Open
kinow opened this issue Mar 31, 2022 · 0 comments
Open

Display a better page for users when we fail to parse the workflow #397

kinow opened this issue Mar 31, 2022 · 0 comments
Assignees

Comments

@kinow
Copy link
Member

kinow commented Mar 31, 2022

Description

From #394 , I think some workflows are failing as the tool is not able to find the commit in the repo (need to debug it to confirm.)

And I think those workflows create unnecessary errors 5xx's. We can do better, displaying some useful message to the user (e.g. "We could not load the selected workflow: git commit not found" and maybe a link to repo & to the commit.)

Expected Behavior

If the workflow is found, i.e. it exists in our DB, then we return a 2xx page, with either the workflow contents (graph/description/etc) or a message explaining why we couldn't render it.

Actual Behavior

Error 5xx.

Possible Fix

Steps to Reproduce

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, Java 1.8):
@kinow kinow self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant