Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird install location for libcmark.a #238

Closed
ghost opened this issue Oct 12, 2017 · 2 comments
Closed

Weird install location for libcmark.a #238

ghost opened this issue Oct 12, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 12, 2017

cmark 0.28.1 now installs libcmark.a into ${CMAKE_INSTALL_PREFIX}/include which seems like an odd choice to me. Is this intentional?

Ran into this while trying to update the FreeBSD port. I currently patch it like this:

--- src/CMakeLists.txt.bak	2017-10-11 06:13:55.000000000 +0200
+++ src/CMakeLists.txt	2017-10-12 12:33:38.920390000 +0200
@@ -130,7 +130,7 @@
   EXPORT cmark
   RUNTIME DESTINATION bin
   LIBRARY DESTINATION ${libdir}
-  ARCHIVE DESTINATION include
+  ARCHIVE DESTINATION ${libdir}
   )
 
 if(CMARK_SHARED OR CMARK_STATIC)
@jgm jgm closed this as completed in a54e12c Oct 12, 2017
@jgm
Copy link
Member

jgm commented Oct 12, 2017 via email

@ghost
Copy link
Author

ghost commented Oct 12, 2017

Thank you for fixing this so quickly and putting out a new release.

I just committed the update to the FreeBSD ports tree: https://svnweb.freebsd.org/changeset/ports/451911

talum referenced this issue in github/cmark-gfm Sep 14, 2021
Due to a mistake, 0.28.1 installed libcmark.a into include/.

Closes #238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant