Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner compass does not change directly even after I walk past the place #5455

Closed
nicolas-raoul opened this issue Jan 19, 2024 · 3 comments
Closed
Assignees
Labels

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Jan 19, 2024

The banner compass indicates the right direction (for instance North) at first, but then as I go around the place (because there are other buildings around it), the compass continues to show the same direction (North), even though the place is now actually in another direction (West).

It would be great if the compass direction could update based on my position and the position of the place.

This otherwise great feature was introduced via #5433.

@ShashwatKedia
Copy link
Contributor

I don't think this should happen, but I will still test this and resolve this bug. This might also be solved when I do a PR for resolving #5444 because updating the banner as the user moves will automatically update the direction of the compass as well ;)

@ShashwatKedia
Copy link
Contributor

@nicolas-raoul I think this issue can also be marked as completed, as it was resolved via #5459. What do you think?

@nicolas-raoul
Copy link
Member Author

Yes thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants