5282: Resume uploads that get stuck because of app being killed or device being rebooted #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… killed or device being rebooted
nicolas-raoul
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Code looks great.
Tested on 10 multiuploads of up to 15 pictures, cutting the Internet twice, rebooting once, closing the app via swipe 5 times: All pictures eventually uploaded well (included one queued which required a different upload to get unstuck), just one shown as non uploaded despite being uploaded.
Thanks Ritika!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5282
What changes did you make and why?
Added
checkAndResumeStuckUploads()to check for any stuck uploads from the database and resume them.Tests performed (required)
Tested prodDebug on Redmi 5A with API level 27.