Resolved #5411 by rotating button initially #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Dec 31, 2023
ShashwatKedia
force-pushed
the
issue5411ShashwatKedia
branch
from
99323ca
to
eb47341
Compare
|
@nicolas-raoul changes done, kindly review :) |
nicolas-raoul
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5411
What changes did you make and why?
I rotated the image button by 180 degrees in the xml file itself so that initially, the arrow points downward instead of upwards (which is the bug)
Tests performed (required)
Tested betaDebug on OnePlus Nord CE 2 Lite with API level 31.
Screenshots (for UI changes only)
DARK MODE
Before:
After:
LIGHT MODE
Before:
After: