Resolves Issue #5413 Crash when opening Nearby when location permission hasn't been granted yet #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
changed the title
ShashwatKedia
force-pushed
the
issue5413SK
branch
from
baf458c
to
4055243
Compare
|
Hey @ShashwatKedia! Thanks for working on this. 🙂 I gave the change in this MR a try and could confirm that the app no longer crashes with the steps described in the issue. Let me check a bit more and let you know if there's anything left to do. |
ShashwatKedia
force-pushed
the
issue5413SK
branch
from
4055243
to
9db46ef
Compare
This was referenced Jan 21, 2024
|
@sivaraam or @nicolas-raoul , if all is good, could you merge this PR? It seems that this particular bug is causing a lot of problems in testing for other issues, especially while testing the nearby fragment. |
nicolas-raoul
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5413
What changes did you make and why?
I saw that the app crashed because a function inside ActivityResultCallback, was being called even without the user giving/denying permission. Also, the code was using RequestMultiplePermissions when, in reality, we were requesting only one permission, so I updated the code to RequestPermission, which also solved the above problem. Moreover, when location permission was not given, in the getMapCenter, mapCenter was null when trying to extract latitude from it, so I assigned mapCenter to lastKnownLocation (after retrieving it) to prevent the exception, if null.
This can also happen with getMapFocus and getLastMapFocus, as even mapView and lastMapFocus are not being checked for a null value, but I did not change that, as I felt it was out of the scope of this exception.
Tests performed (required)
Tested betaDebug on OnePlus Nord CE 2 Lite with API level 31 and Emulator Pixel 7 Pro with API level 34.